refactor(bdk_hwi): remove bdk_hwi, as HWISigner's being moved to rust-hwi
#1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleonardolima
changed the title
bdk_hwi, as HWISigner's being moved to rust-hwi
oleonardolima
force-pushed
the
refactor/remove-bdk-hwi
branch
from
9570ca6 to
4ddc6ba
Compare
oleonardolima
commented
Aug 16, 2024
oleonardolima
force-pushed
the
refactor/remove-bdk-hwi
branch
from
4ddc6ba to
0708329
Compare
|
bitcoindevkit/rust-hwi#104 is merged. |
It seems this file was left out on the previous migration from hardware signers from `bdk_wallet` crate to the `bdk_hwi`, but it should've been removed.
notmandatory
force-pushed
the
refactor/remove-bdk-hwi
branch
from
94195dc to
687ace9
Compare
- removes `bdk_hwi` crate, as `HWISigner`'s being moved to rust-hwi. - please refer to: bitcoindevkit/rust-hwi#104
notmandatory
force-pushed
the
refactor/remove-bdk-hwi
branch
from
687ace9 to
75c97a6
Compare
|
I rebased this PR and removed the |
Thanks! I just noticed that I forgot to remove the |
8 tasks
This was referenced Sep 13, 2024
Closed
Closed
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1516
depends on bitcoindevkit/rust-hwi#104
Description
This PR removed the
bdk_hwicrate, and the danglinghardwaresigner.rsfile frombdk_walletcrate.It simplifies the BDK project workspace as it removes the dependency on
rust-hwi, pyo3 and some required steps on CI.The removal is fine, as the
HWISigneris being moved torust-hwiproject instead, please check: bitcoindevkit/rust-hwi#104Notes to the reviewers
Please let me know what you think about the removal, and if I missed anything.
Changelog notice
hardwaresigner.rsfile frombdk_walletcrate.bdk_hwicrate, moved torust-hwiproject.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: